search

eldang / ballard-4culture

A webmap of the history of the residents of Old Ballard, funded by the King County 4Culture grant program.
0 stars 0 forks source link

Hack to make sure all points get displayed for a given person #19

Closed eldang closed 2 years ago

eldang commented 2 years ago

In investigating the Ted & Ruth Peterson issue listed at https://github.com/eldang/ballard-4culture/issues/15 I learned that this in fact affects many people; maybe all of the people with > 2 associated places. I don't entirely understand what's going wrong here, but it looks like the Mapbox filter we set to show specific places sometimes ignores the first ID in the list. So I worked around it by prepending an ID that's guaranteed not to match any places.

I've stepped through the people dropdown and verified that after this change every person gets the same number of points visible on the map as place IDs in their people.json record. So if there are any other discrepancies then the error must be further upstream, in the generation of that file.

eldang commented 2 years ago

This can safely be merged before or after https://github.com/eldang/ballard-4culture/pull/18 & https://github.com/eldang/ballard-4culture/pull/17 because they're in separate enough parts of the code to not interact with each other at all.