search

eldang / ballard-4culture

A webmap of the history of the residents of Old Ballard, funded by the King County 4Culture grant program.
0 stars 0 forks source link

Popups #5

Closed eldang closed 2 years ago

eldang commented 2 years ago

Tabbed popups are working! Some notes:

  1. The first time you sync this from Github expect it to take a while. For some reason all the mp3s had been previously truncated at 31 seconds; this PR fixes that but it means there's a lot of data to pull.
  2. In theory the a browser which can't handle the HTML5 audio tag should just get a link to download the MP3 instead, but I haven't tested this yet.
  3. I think I'd better convert the list of photos to a carousel along the lines of https://www.w3schools.com/howto/howto_js_slideshow.asp . That tutorial looks pretty easy to follow, I just ran out of time today.
  4. I tried to put fields in a logical order in the popups and give them sensible header text, but I bet you'll want to rearrange it some and hopefully that's easy to do.
  5. I have only done the absolute bare minimum of styling work.
  6. I'm trying to work out why Dorothy Starr (6411 Seaview)'s audio link doesn't work. The file appears to be fine.

There are bound to be other issues that come up as you go, but hopefully this gives you something solid to work with.

eldang commented 2 years ago

@coregis sorry I requested review before writing the comment! It should make sense if you click through now.