eldang / elevation_lookups

Takes an input file of paths described as series of points, outputs a file of data about the elevation changes along those paths.
Apache License 2.0
3 stars 2 forks source link

Input parsing #1

Closed eldang closed 3 years ago

eldang commented 3 years ago

This isn't a very useful project yet! But this is a chunk of work that makes sense together. So far:

  1. Opens an input file
  2. Parses all the coordinates in it, keeping them organised as polylines
  3. Identifies the bounding box for all of those lines

To do next:

  1. I need to come up with a metadata specification for elevation data sources, to include their bounding boxes (to choose which data source to use for a given input file) and the date the source was last checked (to facilitate keeping local copies up to date)
  2. Pick a data source based on the bbox
  3. Start processing coordinates!
  4. Save output
eldang commented 3 years ago

@dabreegster It's your call whether we:

a) Apply a strict code review protocol, i.e. I don't merge anything without your sign-off. b) Treat PRs are more FYI, i.e. I'll always request your review but won't necessarily wait to hear back before moving on. c) Stop tagging you in PRs because it's too much noise.

I'm defaulting to (b) for now. I'll probably merge this tomorrow morning if you don't object, and I'm going to start the design work for handling data sources today, without waiting to hear back.

eldang commented 3 years ago

Heh, actually I can't formally request review until/unless you accept the invitation to collaborate. I suppose that makes sense because it could be use to spam or harass people (deluge of PRs for changes that just add "bla bla bla {person} is a {slur}" comments, etc).

dabreegster commented 3 years ago

(b) sounds good to me.

Everything here seems fine so far. I've never seen Python's new gradual types in a real project before, so I'm excited to learn a bit by watching this evolve!

eldang commented 3 years ago

Haha, the type hints are a bit of a shiny-and-new thing for me too, just picked up from a collaborator over the past couple of months.

eldang commented 3 years ago

@all-contributors please add @eldang for bug, code, doc, projectManagement, review

allcontributors[bot] commented 3 years ago

@eldang

I've put up a pull request to add @eldang! :tada: