eldang / elevation_lookups

Takes an input file of paths described as series of points, outputs a file of data about the elevation changes along those paths.
Apache License 2.0
3 stars 2 forks source link

SRTM lookups now work across integer lat/lon lines #10

Closed eldang closed 3 years ago

eldang commented 3 years ago

In this PR:

Tagging Anchorage (14,121 paths, spans across -150 longitude) takes 1m30s on my machine.

Work for the rest of this week, unless @dabreegster thinks these no longer make sense:

  1. Parallelising lookups
  2. Turning CONTRIBUTING.md into a usable document

Possible later steps:

eldang commented 3 years ago

After opening this PR I investigated an apparent free lunch I was getting, and it was of course no such thing. Closing to fix the bug; will reopen when fixed.

dabreegster commented 3 years ago

Sorry for the slow response, few more things came up. I'll try and get the SRTM data validated soon and see how the bridges turn out -- but it might be Tues or Wed now. Your plan for the rest of the week looks good, regardless!

dabreegster commented 3 years ago

LGTM code-wise. I'm rebuilding my local Docker container and running the import to compare contours, SRTM, and LIDAR.