eldang / elevation_lookups

Takes an input file of paths described as series of points, outputs a file of data about the elevation changes along those paths.
Apache License 2.0
3 stars 2 forks source link

Docker file size fix #23

Closed eldang closed 3 years ago

eldang commented 3 years ago

The COPY command in the Dockerfile was copying the entire contents of my data subdirectory. When I had a copy of the King County LIDAR saved there that was enough to break things. This update just makes it a little more selective about what gets copied in.

dabreegster commented 3 years ago

LGTM, thanks -- and also for all of the SRTM fixes! I'll regenerate all maps in abst, across the world, and have all of them pull in elevation data now.

eldang commented 3 years ago

One detail to check: I think that because of https://github.com/eldang/elevation_lookups/issues/24 the Seattle LIDAR numbers may currently be off by a factor of 3 point something. Relative elevations should make sense, and SRTM is conveniently in metric in the first place.

eldang commented 3 years ago

False alarm. Looking at the Seattle LIDAR source file, it's clearly in metric to begin with. I still want to fix #24 so that the first person to use a raster source in feet doesn't get a nasty surprise, but for now that omission isn't going to cause any errors.