search

eldang / elevation_lookups

Takes an input file of paths described as series of points, outputs a file of data about the elevation changes along those paths.
Apache License 2.0
3 stars 2 forks source link

Fix Dockerfile #30

Closed dabreegster closed 3 years ago

dabreegster commented 3 years ago

Without the trailing slash, I got a "When using COPY with more than one source file, the destination must be a directory..." error

Also, https://hub.docker.com/r/abstreet/elevation_lookups now exists!

eldang commented 3 years ago

Oh, nice!

eldang commented 3 years ago

Interesting that it needs the trailing slash on your system and didn't on mine. I wonder if there was a Docker update in between that changed the behaviour or something.

In any case, when I run this version now the COPY lines all go fine. With either version (this PR or the current main) I then get the error The repository 'http://archive.ubuntu.com/ubuntu focal-backports InRelease' is not signed. at [6/9] RUN apt-get update.

This looks to me like a transient network infrastructure thing, so I'm very much inclined to merge this PR and just leave myself a note to re-test tomorrow. But I think you have a lot more experience with Docker than me - does this sound right to you?

eldang commented 3 years ago

Correction: that turns out to be the cryptic error message you get if Docker hits storage limits with "dangling" images and builds. https://stackoverflow.com/questions/59139453/repository-is-not-signed-in-docker-build sorted me out. So now I've verified that this does work on my machine too.

dabreegster commented 3 years ago

Interesting that it needs the trailing slash on your system and didn't on mine. I wonder if there was a Docker update in between that changed the behaviour or something.

It's probably related to the version, yes. I'm on an old laptop that at first had Docker 18. Thinking this might be the problem, I updated to 20.10.6, but had the same error. I'm guessing the change is innocuous even on whatever version I happened to be using the first round.

that turns out to be the cryptic error message you get if Docker hits storage limits with "dangling" images and builds

It's great Google + Stack Overflow exist, I would've never guessed what this indicated