Contour lookups - Githubissues

eldang / elevation_lookups

Takes an input file of paths described as series of points, outputs a file of data about the elevation changes along those paths.

Apache License 2.0

3 stars 2 forks source link

Contour lookups #5

Closed eldang closed 3 years ago

eldang commented 3 years ago

In this PR:

If we have a contours data source we can process a file, and the results seem to make sense.
A decent start on a useful README

To come in future PRs:

Ability to use SRTM where we don't have contours
A useful CONTRIBUTING.md

eldang commented 3 years ago

Today's work sped up contour lookups considerably: processing the montlake sample data file now takes ~4 minutes on my laptop, from 18-19 yesterday.

eldang commented 3 years ago

Nice! 4 minutes is still a bit slow, but I think there are ways to mitigate that on my end. I also imagine parallelizing the queries could be an easy win, since there's no mutations to the geopandas data happening.

I asked this in the comments on https://github.com/eldang/elevation/pull/3 but I'll repeat it here lest that get lost in a closed PR: does it make more sense for me to add SRTM next, or do the parallelising of lookups?