eldargab / easy-table

Nice text table for Node.js
314 stars 31 forks source link

convert to TS, get more traction #23

Closed ORESoftware closed 6 years ago

ORESoftware commented 6 years ago

I am looking for a cli-table library written with TypeScript.

This lib might get more traction if it were written in TS?

eldargab commented 6 years ago

Hello,

Rewrite is not planned, but type definitions are already available - @types/easy-table. Hope, that will be enough.

nikeee commented 6 years ago

Maintainer of the TS definitions here. If you want, we can move the type definitions to this repository, as it is the preferred way of distributing type definitions.

eldargab commented 6 years ago

@nikeee hello, let's do it. PR is welcome.

ORESoftware commented 6 years ago

tbh this codebase is small, why not write it in TS? Separate type declarations are almost always out of sync.

nikeee commented 6 years ago

I think this would be the next step. Migration to TypeScript would not be that much.

Separate type declarations are almost always out of sync.

Thats why they get removed from DT when the package is released.

ORESoftware commented 6 years ago

What I mean, is not only that the d.ts file(s) move to this repo, but that this whole repo is written in TS

nikeee commented 6 years ago

I know.