search

eldargab / node-fake-fs

Fake node.js file system for testing
32 stars 5 forks source link

rmdir should produce error 'ENOTEMPTY' when a directory is not empty #3

Closed kdvolder closed 11 years ago

kdvolder commented 11 years ago

Right now I think it deletes the directory without producing an error.

kdvolder commented 11 years ago

Please ignore previous fix attempt which didn't work. The pull request #4 does work. It is indirectly tested by some tests in our own codebase which use fake-fs, but I did not add any regression tests to fake-fs itself.

eldargab commented 11 years ago

Thanks for reporting.

kdvolder commented 11 years ago

Thanks for fixing it so quickly, and thanks for fakefs in general. It is a very useful testing tool :-)