Ethernet Delimiter is incorrectly spelled 'Dilimeter'

eldarkg / emdr1986x-std-per-lib

Milandr MCU 1986x Standard Peripherals Library. Mirror:

https://code.launchpad.net/~eldar/emdr1986x-std-per-lib/+git/emdr1986x-std-per-lib

47 stars 28 forks source link

Ethernet Delimiter is incorrectly spelled 'Dilimeter' #39

Closed Amomum closed 6 years ago

Amomum commented 6 years ago

In structure ETH_InitTypeDef there is a field - Dilimeter. It should be spelled 'Delimiter' (as it was spelled in older versions of SPL where everything was prefixed 'opora', as it is spelled in datasheet and in plain english).

I'm afraid that renaming the filed this will be breaking API change :(

eldarkg commented 6 years ago

@Amomum I don't that this is a big problem. The current name isn't accordance the datasheet. Can you create a pull request?

Amomum commented 6 years ago

@eldarkg I sure can but this structure is part of public API, so changing this field will break compilation. And it will break compatibility with 'official' SPL I have no idea if this is a real problem though.

So I'm not sure if we should change it

eldarkg commented 6 years ago

@Amomum Early I applied one for ADC. I think we can apply another one. The official lib should be updated too (but the last from 06.10.2015 - it is so old. The current SPL fix some issues that official don't).