search

elderfo / react-native-storybook-loader

An automatic story loader for react-native-storybooks
https://github.com/elderfo/react-native-storybook-loader
MIT License
299 stars 27 forks source link

feat: strip story files extensions in require calls #52

Closed no23reason closed 6 years ago

no23reason commented 6 years ago

The extensions in the generated loader file are stripped to allow for transpiled files (e.g. tsx) to be used as well.

Closes #51

no23reason commented 6 years ago

To be honest, I don't understand why the Travis build fails. When I run yarn test:ci locally, it runs with no problems...

elderfo commented 6 years ago

The PR looks good, thank you. I am going to dig into the travis problem and see if I can figure out what's going on.

elderfo commented 6 years ago

I am going to go ahead and merge this, unfortunately it won't be released until the CI issue is resolved. I won't be able to fix it until this evening after work (I'm in the US). As a temporary solution you should be able to point the react-native-storybook-loader dependency to https://github.com/elderfo/react-native-storybook-loader.git.

no23reason commented 6 years ago

Thank you, it is not that urgent :)