eldritch-theme / eldritch.nvim

A theme for the Ancient Ones! (NVIM)
MIT License
172 stars 6 forks source link

Issue with color in rename mode #6

Closed whitewolf185 closed 5 months ago

whitewolf185 commented 6 months ago

Hi! Could you please fix colors in rename mode?

In picture below, i was pressed rename function name and cannot see what text is selected or not. (spoiler: it is selected) image

jacobrreed commented 5 months ago

Hi! Could you please fix colors in rename mode?

In picture below, i was pressed rename function name and cannot see what text is selected or not. (spoiler: it is selected) image

Sorry can you tell me what's wrong with your picture? I can clearly see the text selected? Or do you not like ye contrast

whitewolf185 commented 5 months ago

Hi! Here I cannot see what I've just choose

image

jacobrreed commented 5 months ago

Hi! Here I cannot see what I've just choose

image

Are you referring to the backdrop of the rename window? The functionality of where that window displays has nothing to do with the theme

whitewolf185 commented 5 months ago

I thought maybe the whole background could be more lighter, like #4A4D6A (Maybe not this light, but a little bit)

It would be like this image

Also, I see this problem with files which were influenced by gitignore

Under "whole" I mean like whole IDE

jacobrreed commented 5 months ago

You can override any highlights or colors you want with on_colors or on_highlights functions in the confg for theme. I do agree that specific instance does look better you can open a PR and I can check it out

whitewolf185 commented 5 months ago

Could you give me, please, a hint where those settings are?

I never changed themes before

jacobrreed commented 5 months ago

You'd have to check what highlight group that code rename action window iis in nvim, then you can find it in https://github.com/eldritch-theme/eldritch.nvim/blob/master/lua/eldritch/groups if it exists , if not you'll have to add an override line there for the highlight group name

whitewolf185 commented 5 months ago

Thanks a lot!

I will try to figure it out and I'll try to make a PR when I get some free time

jacobrreed commented 5 months ago

@whitewolf185 image

This is what I see btw