search

eldruin / ads1x1x-rs

Platform-agnostic Rust driver for the ADS1x1x ultra-small, low-power analog-to-digital converters (ADC). Compatible with ADS1013, ADS1014, ADS1015, ADS1113, ADS1114 and ADS1115
https://blog.eldruin.com/ads1x1x-analog-to-digital-converter-driver-in-rust/
Apache License 2.0
31 stars 9 forks source link

Remove `DynamicOneShot` trait. #19

Closed reitermarkus closed 3 weeks ago

reitermarkus commented 5 months ago

From reading https://github.com/eldruin/ads1x1x-rs/issues/10#issuecomment-890776015, it looks like adding this trait didn't actually solve the issue.

Depending on the device, this also allows reading invalid channels.

coveralls commented 5 months ago

Coverage Status

coverage: 81.385% (+0.2%) from 81.197% when pulling 4f46a6e07c19ef9b0ac254a8114ed54ce56a6c0f on reitermarkus:remove-dynamic-one-shot into 0ff4c7b448fd388015d4903b774c63991356b954 on eldruin:master.

reitermarkus commented 5 months ago

@eldruin, rebased the PRs.

reitermarkus commented 4 months ago

@eldruin, can you have another look here? Thanks.

reitermarkus commented 1 month ago

@eldruin, please review this again. Thanks.