Set comparator to default on continuous pulse

eldruin / ads1x1x-rs

Platform-agnostic Rust driver for the ADS1x1x ultra-small, low-power analog-to-digital converters (ADC). Compatible with ADS1013, ADS1014, ADS1015, ADS1113, ADS1114 and ADS1115

https://blog.eldruin.com/ads1x1x-analog-to-digital-converter-driver-in-rust/

Apache License 2.0

32 stars 8 forks source link

Set comparator to default on continuous pulse #27

Closed Slabity closed 2 months ago

Slabity commented 4 months ago

Took longer than I expected to find the time to submit this change, but it's to fix #26

@eldruin - Going to be honest, I have no idea what those tests you mentioned in that issue are suppose to do in this particular case. It looks like it's suppose to check that it doesn't break the boards that don't use it as a conversion-ready pulse? But I'm not sure this function call would be appropriate at all for those boards that don't support it anyways.

eldruin commented 2 months ago

I have incorporated this manually and fixed the test. Thank you!