Closed reitermarkus closed 2 years ago
I would remove the
bitflags
dependency, though, since it is only for debug and it brings its own dependencies and additional MSRV policy.
I have another WIP branch which adds dedicated types for all registers using bitflags
with many more improvements so removing the dependency here would cause a lot of conflicts and be a pain to rebase.
Also, this is a API-breaking change anyways, so might as well increase the MSRV.
I see. The MSRV update policy of bitflags
is apparently fine (although not properly documented) and no other build dependencies are added if not using features, so ok.
Could you add an entry to the changelog?
Then this would be good to go.
@eldruin, I added a changelog entry.
u8
instead of as multiplebool
s.bitflags
for the status flags to get nicer debug output. Also renamed the flags to match the datasheet.