eldruin / lsm303agr-rs

Platform agnostic Rust driver for the LSM303AGR ultra-compact high-performance eCompass module: ultra-low-power 3D accelerometer and 3D magnetometer
Apache License 2.0
18 stars 14 forks source link

Reduce size of status structs. #11

Closed reitermarkus closed 2 years ago

reitermarkus commented 2 years ago
reitermarkus commented 2 years ago

I would remove the bitflags dependency, though, since it is only for debug and it brings its own dependencies and additional MSRV policy.

I have another WIP branch which adds dedicated types for all registers using bitflags with many more improvements so removing the dependency here would cause a lot of conflicts and be a pain to rebase.

Also, this is a API-breaking change anyways, so might as well increase the MSRV.

eldruin commented 2 years ago

I see. The MSRV update policy of bitflags is apparently fine (although not properly documented) and no other build dependencies are added if not using features, so ok. Could you add an entry to the changelog? Then this would be good to go.

reitermarkus commented 2 years ago

@eldruin, I added a changelog entry.