search

eldruin / lsm303agr-rs

Platform agnostic Rust driver for the LSM303AGR ultra-compact high-performance eCompass module: ultra-low-power 3D accelerometer and 3D magnetometer
Apache License 2.0
18 stars 14 forks source link

Replace `Config` with explicit register types. #17

Closed reitermarkus closed 2 years ago

eldruin commented 2 years ago

Do we need a higher MSRV?

reitermarkus commented 2 years ago

const_panic is in 1.57. I have replaced the unreachable! with a default match case instead for now.

eldruin commented 2 years ago

Uh, sorry but commit fc24b44 contains way too many fiddly changes for me to review timely. It will take me a while to go over it. A mitigation would be splitting into several commits, if that is something you would be willing to do.

reitermarkus commented 2 years ago

Sure, I'll try to split some of this out.

reitermarkus commented 2 years ago

I extracted some of this out into https://github.com/eldruin/lsm303agr-rs/pull/19.

reitermarkus commented 2 years ago

@eldruin, I think this should be good to go now. Don't think I can split this further.