WatchList Test - Githubissues

Hunsu commented 9 years ago

I completed WatchList Test

Hunsu commented 9 years ago

I added Watch/Unwatch functionality. I found one bug when trying to get revisions of multiples pages (mustn't add rvlimit parameter).

eldur commented 9 years ago

Cool thanks for you work, but as I asked before, can you give me a hint what raw change is please? You've changed about ~7000 lines with your pull request (the project has only ~20000 lines of java code)

A few questions/suggestions?

Why have you disabled checkstyle? Please rollback all you pom.xml changes.
Please reformat your changes to max length 100 and indentation with 2 spaces please, it helps me to see the real diff and speeds up the merge process
try to rebase and squash your commits (e.g. We don't need commits with titles like "checkstyle" or "removed print" or changes that will fail on CI Server in the history :wink: ) ... you can also force push your changes to update this pull request
It seems that pull #49 has the same changes like #48, do we really need both?

Hunsu commented 9 years ago

Now GetRevision, GetApiToken, PostDelete, MovePage uses json format. So to be able to do this I added some Json parsing function in JsonMapper class. I added a static function in MediaWiki to check whatever a api response contains error.

I added a two functions in MediaWikiBot (watch/unwatch) to be able to a list of article to user watchlist. To do this I created a WatchUnwatchAction class. I also modified Wikibot interface to add this two function. I also added this function in Article.

Normally these are the big changes. I have tried to correct some checkstyle warnings and errors.

I have disabled checkstyle to be able to excute mvn test clean. The first time I have though that I must correct all 200 checkstyle warnings.

I have added your checkstyle file to my project configuration. Now I see checkstyle warnings in my eclipse.

Yes pull #49 and #48 are the same. I tried to make two pull request: one for the json format changes and the second for watch/unwatch functionality. I don't how to do it.

eldur commented 9 years ago

Okay I'll try to extract these changes, but give me time, I have to check 7000 lines ... I also close pull #49 ... hmm

eldur commented 9 years ago

accepted in branch https://github.com/eldur/jwbf/tree/hunsu-master ... further conversion in #45

eldur / jwbf

WatchList Test #48