search

eldy / AWStats

AWStats Log Analyzer project (official sources)
https://www.awstats.org
370 stars 120 forks source link

Escape geoip html #69

Closed watercrossing closed 5 years ago

watercrossing commented 7 years ago

The geoip plugin prints a number of html special characters without escaping them - & <>. I have done the lazy fix for this and used the encode_entities function from HTML::Entities. This fix is done in 7e5317605d98b8f46a0b5b2848cb7cc8166d6a89.

The second commit is entirely style - the two geoip plugin files have no discernible style at all, so i have applied some standard formatting. I did not find any guidance on the formatting for awstats, but I will re-format if you let me know.

eldy commented 5 years ago

Can you make your PR "Add html escaping to geoip" into a separate PR that differs from indentation ?

watercrossing commented 5 years ago

I have rebased the original fix to the latest develop and removed the indentation fix.

eldy commented 5 years ago

Should be fixed by #131