search

ele828 / hexo-prism-plugin

Hexo plugin for code highlighting by prism.js, supporting JSX syntax
205 stars 51 forks source link

line_number not shown #12

Closed cubesky closed 7 years ago

cubesky commented 7 years ago

I set line_number to true and line_number not work.

See https://liyin.date/2017/01/21/Minecraft-with-Docker/

neoFelhz commented 7 years ago

I think we should patch the css about linenumber to fix it. This is demo after my patch. https://blog.neofelhz.space/archives/coding-snapdragon-810-down.html

ele828 commented 7 years ago

@cubesky Actually I don't have time to look into this now.

@neoFelhz I would really appreciate it if you could send us a pull request about that patch :) thanks!

neoFelhz commented 7 years ago

@ele828

The idea comes from @cubesky

neoFelhz commented 7 years ago

I think I should send the PR to prismjs. The bug is not caused by the plugin it self, it caused by dependencies.

ele828 commented 7 years ago

@neoFelhz thanks for digging into this issue. It would be nice if you could make a pull request to fix it :)

neoFelhz commented 7 years ago

I have send a PR to them right now. :)

ele828 commented 7 years ago

@neoFelhz 👍