search

ele828 / hexo-prism-plugin

Hexo plugin for code highlighting by prism.js, supporting JSX syntax
204 stars 51 forks source link

feat(themes): Allow using themes from PrismJS/prism-themes #22

Closed ValentinFunk closed 7 years ago

ValentinFunk commented 7 years ago

This makes it possible to use the themes from https://github.com/PrismJS/prism-themes in addition to the standard themes.

ValentinFunk commented 7 years ago

@ele828 Let me know when you get a chance to look at this :) Would love if this could get merged soon to use in own project :)

If there's anything that could be improved or any questions please do let me know 👍

ele828 commented 7 years ago

Hi @Kamshak, thanks for your contribution. This is a really good improvement!

I left a few comments, would you mind taking a couple minutes to fix them?

And then, I will make it merged ASAP :) Thank you 👍

ValentinFunk commented 7 years ago

Thanks for your quick response and the helpful comments :+1:

I have performed the requested changes and added some comments where the behavior wasn't clear. Let me know what you think :)

ele828 commented 7 years ago

Thank you again for contribution. Since there is a small variable naming issue, I will jump to fix it right way. But anyway, it is merged now. You should be able to use it in your blog in one hour after I publish a new version for it. : )

ValentinFunk commented 7 years ago

Thanks a lot :+1: :confetti_ball: