search

ele828 / hexo-prism-plugin

Hexo plugin for code highlighting by prism.js, supporting JSX syntax
204 stars 51 forks source link

Update hexo-fs to 0.2.1 #29

Closed trile closed 6 years ago

trile commented 6 years ago

Hi ele828, Thank so much for the elegant plugin. I have used and loved it so much.

Since I upgrade to Node8 recently, I found that the hexo-fs package you used in the plugin was a bit outdated and create an unnecessary warning when running hexo server:

DeprecationWarning: fs.SyncWriteStream is deprecated. in Node8

Since your code did not use SyncWriteStream, I tried to update hexo-fs package to the latest version (0.2.1) in package.json file. The warning message disappeared and it worked well for my blog.

I created this pull request for the change. Here is the thread in Hexo discussed about the warning message and updating hexo-fs:

fs.SyncWriteStream is deprecated [Nodejs v8.0]

Thanks again for the great plugin.

ele828 commented 6 years ago

Thanks for your contribution!

trile commented 6 years ago

My pleasure! Thanks for such useful plugin.