search

ele828 / hexo-prism-plugin

Hexo plugin for code highlighting by prism.js, supporting JSX syntax
204 stars 51 forks source link

Removed prismjs files from repo and made it as an external dependency #8

Closed ibhi closed 7 years ago

ibhi commented 7 years ago

Removed prismjs files from this repository and moved it as an dependency in package.json. In this way no need to update this repositories prismjs files whenever prismjs releases new version or adds new features/plugins. Note: Also this repository code and the code installed from npm are not the same. The npm version doesnt have the code for line numbers support.

ele828 commented 7 years ago

After testing this big change, I found out it doesn't work in some specific languages like jsx, objective-c , etc.

I investigated a little bit and personally think it's because your didn't import all of those predefined language supports of Prism.js

So for now, I temporarily revert the changes, and if you have any solutions, feel free to commit it. I will also look at it these days.

Thanks!