search

elearningsoftware / moodle-mod_journal

The Moodle journal module for moodle 2.0+
https://moodle.org/plugins/view.php?plugin=mod_journal
16 stars 34 forks source link

Privacy provider does not export or delete journal entries which the specified user has rated #106

Open larsbonczek opened 3 months ago

larsbonczek commented 3 months ago

The privacy provider only supports exporting and deleting journal entries where the specified user appears in the userid column. However, the teacher column also contains a user ID: The user who has rated the journal entry (and may have added a comment in the process).

If you look at mod_assign, you will notice that they do export contexts based on the grader column in the assign_grades table. This behavior needs to be replicated in mod_journal.

larsbonczek commented 3 months ago

Thinking about this, we should not delete journal entries rated by a given user, because this would also delete other user's data. They should still be included in the export, though. This appears to be what mod_assign does as well.