search

elearningsoftware / moodle-mod_journal

The Moodle journal module for moodle 2.0+
https://moodle.org/plugins/view.php?plugin=mod_journal
16 stars 34 forks source link

Poet 30.1 #18

Closed mchurchward closed 8 years ago

mchurchward commented 8 years ago

Hi. I ran your plugin through Travis CI using the ".travis.yml" file in this commit. I used the base tag "v1.30.1" as the starting point. These changes allow the plugin to pass all of the tests defined by "moodle-plugin-ci", which includes all Moodle coding standards. If you are interested, you can merge this and have the plugin meet all of the Moodle coding standards. You had a ".travis.yml" file already that I moved out of the way. If you still need it, you'll want to switch it back.

mchurchward commented 8 years ago

If you want to see the test results, the original is here - https://travis-ci.org/POETGroup/moodle-mod_journal/builds/102125998 The one for this pull request is here - https://travis-ci.org/POETGroup/moodle-mod_journal/builds/102161924

dmonllao commented 8 years ago

Thanks @mchurchward, I will look at it during these next weeks.

dmonllao commented 8 years ago

Thanks for the pull request. I've fixed some conflicts, removed travis file changes, squashed commits and integrated it to master.