search

elearningsoftware / moodle-mod_journal

The Moodle journal module for moodle 2.0+
https://moodle.org/plugins/view.php?plugin=mod_journal
16 stars 34 forks source link

Add necessary function return types to privacy provider implementation #48

Closed tobiasreischmann closed 4 years ago

tobiasreischmann commented 5 years ago

Fixes #47

Urpokarhu1 commented 4 years ago

Hello,

We have tested this fix and it works, can you add it to the master? @tobiasreischmann

tobiasreischmann commented 4 years ago

I am not allowed to merge anything, unfortunately.

adrian-sarmas commented 4 years ago

Thanks @tobiasreischmann. I did notice Travis build fails for your pull request. Could you also edit .travis.yml to make this build pass?

tobiasreischmann commented 4 years ago

Sorry for the delay. I adjusted the travis.yml. I removed php 5.6 and 7.1 since they are out of support. Further, the patch breaks with php 5.6 since return types were introduced with php 7.0. Thus, php 5.6 support should be removed for the next release version. The moodle versions that I removed are due to the fact that they do not support the respective php version.

danmarsden commented 4 years ago

Great! - thanks for that! - makes our job a lot easier when we can use the upstream repo rather than having to maintain a fork.