elearningsoftware / moodle-mod_journal

The Moodle journal module for moodle 2.0+

https://moodle.org/plugins/view.php?plugin=mod_journal

16 stars 34 forks source link

Data privacy issue in Moodle 3.8 #60

Closed jelshoff closed 4 years ago

jelshoff commented 4 years ago

When running a GDPR data export request, the cron returns a fatal error:

Fatal error: Declaration of mod_journal\privacy\provider::get_metadata(core_privacy\local\metadata\collection $collection) must be compatible with core_privacy\local\metadata\provider::get_metadata(core_privacy\local\metadata\collection $collection): core_privacy\local\metadata\collection in .../mod/journal/classes/privacy/provider.php on line 43

This causes the general cron to hang while processing the data export task.

amandadoughty commented 4 years ago

Fix:

72

public static function get_metadata(collection $collection) : collection {

136

public static function get_contexts_for_userid(int $userid) : contextlist {

jelshoff commented 4 years ago

Shouldn't this be fixed by the developer and then deployed to moodle.org/plugins properly? That way all Moodle administrators will benefit.

amandadoughty commented 4 years ago

Of course. I just added the fix for the developer to hopefully get it in asap.

jelshoff commented 4 years ago

Understood... thanks for pointing to the fixes! I know this is an issue that was already mentioned on Moodle Community forums a few months ago, but strangely enough, it hasn't been fixed yet.

argwallace commented 4 years ago

I added these fixes into my version but I still get an error when I try to create a GDPR request. Am I missing something?

danmarsden commented 4 years ago

see pull request #48 for a fix - this was submitted almost 12 months ago now.

@elearningsoftware @adrian-sarmas - is anyone maintaining this plugin on your end?

adrian-sarmas commented 4 years ago

I've merged the pull request. Thank you for your input