search

elearningsoftware / moodle-mod_journal

The Moodle journal module for moodle 2.0+
https://moodle.org/plugins/view.php?plugin=mod_journal
16 stars 34 forks source link

Saving feedback is updating all students grades #61

Closed crystalvaughn closed 2 years ago

crystalvaughn commented 3 years ago

When a journal has multiple entries made by students. If a teacher grades one student journal it updates the other students grades to 0 in the gradebook. Previously the teacher was able to grade one student and saving the feed back would only update the one student.

Steps to recreate:

  1. Log on a Moodle course
  2. Create a journal activity
  3. Log in as student1 and enter a journal entry.
  4. Log in as student2 and enter a journal entry.
  5. Log in as student3 and enter a journal entry.
  6. Log in as the teacher in the course and view the journal entries.
  7. Add feedback and a score to student1's journal entry.
  8. Click the submit all feedback.
  9. All the students feedback and grades are updated.
amandadoughty commented 3 years ago

The rating has a default value of null. If no grade is set in the feedback form then the submitted rating is set to -1. A comparison of null and -1 then sets the logic to upgrade the entry.

I propose changing the rating default to -1. I will provide a fix if this an acceptable solution for the dev team?

will-bulluck commented 3 years ago

I have a client experiencing the same issue on MOODLE_35

will-bulluck commented 3 years ago

Any update on this?

larsbonczek commented 3 years ago

We have encountered this issue in Moodle 3.9. The solution suggested by amandadoughty works for us. Could it please be merged?

will-bulluck commented 3 years ago

Any updates to this?

will-bulluck commented 3 years ago

Any Update on this?

adrian-sarmas commented 2 years ago

I've merged the pull request. Thanks for helping!