elect86 / magik

Maven Artifacts on Github International for Kotlin
Apache License 2.0
43 stars 6 forks source link

Some problems with setting up the plugin #1

Closed kwerber closed 3 years ago

kwerber commented 3 years ago

First of all, I am not that knowledgeable when it comes to gradle, so it is certainly possible that I have missed some things.

I tried using this plugin following the README file but came across two problems:

  1. Gradle is unable to build the project when using the alsoSnapshot() option
  2. Gradle is able to build but unable to publish when not using the alsoSnapshot() option

Some links:

Some additional information:

elect86 commented 3 years ago

Hey Kevin,

so, I pushed some additional logic which hopefully will help with your issues

1) Now you don't need tags anymore for this to work, a -1 will be returned if this is the case. Moreover, now one can set whatever postfix he likes best by passing the ending lambda on alsoSnapshot, default is "+$gitDistance"

2) Now all the backslashes will be switched with normal slashes, I haven't test this though

pull version 0.0.5

let me know if these help

kwerber commented 3 years ago

Both issues seem to have been fixed, thanks!

elect86 commented 3 years ago

Nice, thanks for reporting