search

electerious / basicLightbox

The lightest lightbox ever made.
https://basiclightbox.electerious.com
MIT License
564 stars 55 forks source link

Proposal: passing a node to create #15

Closed funkyfuture closed 6 years ago

funkyfuture commented 6 years ago

i have a scenario where i would rather pass a programatically node to create than an html string. would you accept a patch providing this functionality?

electerious commented 6 years ago

Sounds like a good addition. I'm always converting Nodes to Strings using .outerHTML, but that's kinda stupid. I don't know why I never had the idea to simply support Nodes directly 🤔

electerious commented 6 years ago

basicLightbox v5 is out and includes node elements and templates in .create(). Check out all the examples. It's very powerful and yet super simple to use. Thanks for the suggestion!

https://github.com/electerious/basicLightbox/blob/master/CHANGELOG.md#500---2018-09-23