search

electerious / basicLightbox

The lightest lightbox ever made.
https://basiclightbox.electerious.com
MIT License
564 stars 55 forks source link

Allows to pass node objects as lightbox contents #17

Closed funkyfuture closed 6 years ago

funkyfuture commented 6 years ago

as proposed in #15. i tested it with both input types in my use-case.

electerious commented 6 years ago

Thanks for the PR. I will take a closer look at it by time.

Coriou commented 6 years ago

Interested in the feature too ! Tested for my basic use case and it's working great

electerious commented 6 years ago

Sorry that this feature still hasn't been merged. I'm planning to do some changes to the API of basicLightbox in the next version and this feature should be a part of it. Still may take a while…

Coriou commented 6 years ago

Thanks for the update @electerious

electerious commented 6 years ago

basicLightbox v5 is out and includes node elements and templates in .create(). Check out all the examples. It's very powerful and yet super simple to use. Thanks for the suggestion!

https://github.com/electerious/basicLightbox/blob/master/CHANGELOG.md#500---2018-09-23