search

electerious / basicLightbox

The lightest lightbox ever made.
https://basiclightbox.electerious.com
MIT License
564 stars 55 forks source link

feature request: hash url #8

Closed jimblue closed 7 years ago

jimblue commented 7 years ago

Hi!

First thank you for this very nice piece of code, sharp and clean!

Wondering if you could consider adding hashnavigation for the lightbox.

This script to do this kind of job but using jQuery:

https://github.com/sachinchoolur/lightGallery/blob/master/modules/lg-hash.js

What do you think?

jimblue commented 7 years ago

Also found this interesting library: https://github.com/EastingAndNorthing/urlhash

electerious commented 7 years ago

I try to keep basicLightbox as light and clean as possible. Navigation is complex when you want to implement something that works in all cases (e.g. webapps). It always depends on where you use it.

The good thing: You can easily implement it by yourself using the scripts you mentioned. Just use the API of basicLightbox when the hash changes.

jimblue commented 7 years ago

Sure I understand 😄 !

Thanks for answering @electerious