search

electerm / electerm-web

Running electerm as web app
https://electerm.html5beta.com
MIT License
100 stars 17 forks source link

Scrollbar covering tabs #16

Open jokob-sk opened 5 months ago

jokob-sk commented 5 months ago

electerm-web Version and download file extension(electerm-web版本和下载文件后缀)

2.39.18

Platform detail (平台详情)

docker x86

What steps will reproduce the bug?(重新问题的详细步骤)

Open any tab

What should have happened?(期望的结果)

The tab name shouldn't be covered by a scrollbar

Would this happen in other terminal app(是否能够在其他同类软件重现这个问题)

No response

Additional information(其他任何相关信息)

image

zxdong262 commented 5 months ago

What is the browser and browser version?

jokob-sk commented 5 months ago

Thank you for your response. FIREFOX the latest version I think. I'm on my phone and will be back on the pc later to double check. Great software by the way.

On Sat, 8 June 2024, 21:49 ZHAO Xudong, @.***> wrote:

What is the browser and browser version?

— Reply to this email directly, view it on GitHub https://github.com/electerm/electerm-web/issues/16#issuecomment-2156002925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5URDF5Q3Z7LAPISJU36CDZGLVTBAVCNFSM6AAAAABI73L3NKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGAYDEOJSGU . You are receiving this because you authored the thread.Message ID: @.***>

zxdong262 commented 5 months ago

I see, it is browser compatibality issue, any webkit browser should works fine, I may add a warning that only support webkit browser in next release, thank you for the feeback.

jokob-sk commented 5 months ago

Would be nice if this could be fixed also for FF (it's an overflow scroll as seen in the screeshot), but I understand how hard it is to support multiple browsers. Anyway - I'll probably still use it on FF since it's a great productivity boost :) All the best!

image

zxdong262 commented 5 months ago

Would be nice if this could be fixed also for FF (it's an overflow scroll as seen in the screeshot), but I understand how hard it is to support multiple browsers. Anyway - I'll probably still use it on FF since it's a great productivity boost :) All the best!

image

Sure, let me do something about it

zxdong262 commented 5 months ago

Did some research, copilot tells me that as of late 2018, Firefox introduced limited scrollbar customization options using the scrollbar-width property. Unfortunately, there’s no direct equivalent to ::-webkit-scrollbar, so seems can not control the scrollbar width easily.

zxdong262 commented 5 months ago

Updated, just set scollx to hidden, not a pefect solution, there would some place have similar issue, at least not that obvious as tabs

jokob-sk commented 5 months ago

🙏thanks a lot for the fix. Yes, I couldn't find any other big issues and this will improve the feel of the app quite a bit, even with limited FF support. I know how hard it is sometimes to fully test and support things (https://github.com/jokob-sk/NetAlertX) 😅 Good luck with the project!