Closed jon-xo closed 3 weeks ago
Actually, I had considered adding the keyboard shortcut configuration feature before. But I felt it might be a bit complicated, so I put it aside.
If you're willing to help implement this, that would be fantastic. You're more than welcome to submit a PR.
Yeah, if you're okay with a little bit of iteration maybe implementing pre-defined configurations first, e.g. miniflux or google reader style key bindings first and then stepping that into a full user-configurable customizable shortcuts
In fact, I've already started restructuring. 😄
Thanks to your reminder, I now have a general idea. You can wait a little for my good news.
The refactoring work is complete.
User-defined hotkeys and easier addition of new actions with hotkeys can now be implemented.
The user-defined hotkey feature is implemented.
But it just doesn't look very good. 😂
I redesigned the interaction logic:
This will avoid wasting page space unnecessarily.
It looks like this:
I think the current customizable keyboard shortcuts
are already very well implemented.
Therefore, I will close this issue.
If you have any further issues or feature requests, please open a new issue.
I just started using ReactFlux and found the UI and features perfectly fit my needs. It's a total long shot but I would love it if it would offer an alternative/additional/customizable keyboard shortcuts in the classic Google Reader style. The best record of it I cloud find was on this website: 40 Shortcuts for Google Reader but the top of my list would be
next post:
j
previous post:k
I haven't looked had an in depth look at the codebase yet but would be happy to take a pass at opening a PR if you're down up for it.
Thanks!