search

electh / ReactFlux

A Simple but Powerful RSS Reader for Miniflux
https://reactflux.pages.dev
MIT License
224 stars 65 forks source link

Feature Request: Support Google Reader Style Keyboard Shortcuts #100

Closed jon-xo closed 1 month ago

jon-xo commented 1 month ago

I just started using ReactFlux and found the UI and features perfectly fit my needs. It's a total long shot but I would love it if it would offer an alternative/additional/customizable keyboard shortcuts in the classic Google Reader style. The best record of it I cloud find was on this website: 40 Shortcuts for Google Reader but the top of my list would be

next post: j previous post: k

image

I haven't looked had an in depth look at the codebase yet but would be happy to take a pass at opening a PR if you're down up for it.

Thanks!

NekoAria commented 1 month ago

Actually, I had considered adding the keyboard shortcut configuration feature before. But I felt it might be a bit complicated, so I put it aside.

If you're willing to help implement this, that would be fantastic. You're more than welcome to submit a PR.

jon-xo commented 1 month ago

Yeah, if you're okay with a little bit of iteration maybe implementing pre-defined configurations first, e.g. miniflux or google reader style key bindings first and then stepping that into a full user-configurable customizable shortcuts

NekoAria commented 1 month ago

In fact, I've already started restructuring. 😄

Thanks to your reminder, I now have a general idea. You can wait a little for my good news.

jon-xo commented 1 month ago

image

NekoAria commented 1 month ago

The refactoring work is complete.

User-defined hotkeys and easier addition of new actions with hotkeys can now be implemented.

图片

NekoAria commented 1 month ago

The user-defined hotkey feature is implemented.

But it just doesn't look very good. 😂

图片

NekoAria commented 1 month ago

I redesigned the interaction logic:

  1. Displays the original design by default
  2. Editable only after the user clicks
  3. If it's out of focus, it goes back to normal

This will avoid wasting page space unnecessarily.

It looks like this:

图片

NekoAria commented 1 month ago

I think the current customizable keyboard shortcuts are already very well implemented. Therefore, I will close this issue. If you have any further issues or feature requests, please open a new issue.