search

electionscience / vse-sim

Methods for running simulations to calculate Voter Satisfaction Efficiency (VSE) of various voting systems in various conditions.
https://electionscience.github.io/vse-sim
57 stars 17 forks source link

Change "SRV" to "STAR" in 5vse.png image #45

Closed endolith closed 1 year ago

endolith commented 1 year ago

Wait I already did this in https://github.com/electionscience/vse-sim/pull/27 It got lost somehow?

endolith commented 1 year ago

OK so:

  1. I fixed SRV → STAR in 11755f3a
  2. @fsargent intended to change Irv → IRV/RCV in e8ebb2fe but actually just made the image bigger and (probably unintentionally) changed STAR back to SRV in the process
  3. @fsargent reduced file sizes of images in 3b371f9c but I don't see any actual changes

Anyway I forgot I have commit rights to this repo, so I guess I can fix it myself. 😃 If no one has any comments I will commit it in a day or so.

I also restored the small version of the image alongside the big one, and changed IRV → IRV/RCV in both, as was intended in https://github.com/electionscience/vse-sim/commit/e8ebb2fe60c2b95676033edca7e5c6f10bd534e6.

endolith commented 1 year ago

Oh I guess I can't do it myself. @fsargent can you approve this PR?