select: revert select's dropdown icon to default

electracoin-ECA / electra-desktop

[DEPRECATED]- To be used only on specific request from the Electra team

https://electraproject.org

MIT License

17 stars 9 forks source link

select: revert select's dropdown icon to default #127

Closed Hyjaz closed 6 years ago

Hyjaz commented 6 years ago

This is a fix for issue #103

I removed the following three css properties from select html tag:

-webkit-appearance:none;-moz-appearance:none;appearance:none

ivangabriele commented 6 years ago

Where are the original Sass or CSS files from which this file has been generated ?

Hyjaz commented 6 years ago

For <select /> it's here

It was indeed sort of a bad idea to separate the electra-desktop css. It is kinda harder to maintain in the long term.

ivangabriele commented 6 years ago

It was not a bad idea. But how we do it seems wrong. We should have it as a git submodule or a npm dependency (a npm dependency being easier to handle imo) so that we have to update it to generate the css on this project.

In the meantime, can you add a PR on the Electra-Styleguide too ?

Hyjaz commented 6 years ago

The corresponding PR has been opened on Electra-Styleguide - https://github.com/Electra-project/Electra-Styleguide/pull/2