search

electraone / datafiles

Public files for electra.one project
23 stars 6 forks source link

Test Instrument File contains deviceId #43

Closed jorisroling closed 3 years ago

jorisroling commented 3 years ago

Hi martin,

The Test Instrument File contains a deviceId (line 45), that feels wrong, am I right? 😉

Also in the example part of the Instrument File Schema. And while we are at it, the github pointer at the top of the schema, is not (exactly) correct. It should be https://github.com/martinpavlas/electra.one/blob/master/schemas/instr.json 😉

Could you explain me defaultValue with respect to to midiValue and displayValue?

properties.name is mentioned twice, probably a typo, the first one should be id, right?

jorisroling commented 3 years ago

All fixed