electri / gmapcatcher

Automatically exported from code.google.com/p/gmapcatcher
0 stars 0 forks source link

Add Yahoo Hybrid #203

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm proposing the addition of Yahoo Hybrid, besides the current Map and 
Satellite variants.

Check the attached patch for half of the work. I say *half* because...

1. I couldn't get the hybrid image be displayed on top of the Satellite. It 
shows only the hybrid one.

2. I felt the code was a bit messy. I think it was okay to add the relevant 
data to the big JSON inside mapConst.py, as well as modifying the function in 
mapServers/yahoo.py; but I see no real reason to modify mapServices.py. I think 
the big if inside get_url_from_coord() should be rewritten to automatically 
adapt itself to the changes from MAP_SERVICES JSON.

By the way, the Yahoo URL accepts a language argument, but I've not implemented 
that.

Original issue reported on code.google.com by denilsonsa on 19 Aug 2010 at 1:41

Attachments:

GoogleCodeExporter commented 8 years ago
Looks good; the inability to overlay in onedirpermap mode may be a result of 
the overlay code that currently assumes LAYER_HYBRID [= google hybrid in 
onedirpermap] would be the layer, rather than, as it would be in onedirpermap 
mode, the Yahoo Hybrid layer

so it works when you switch off onedirpermap, although looks as though it's 
overlaying hybrid + terrain rather than hybrid + sat;

Either way, the patch is now committed as r973

Original comment by Mark111...@gmail.com on 19 Aug 2010 at 6:52

GoogleCodeExporter commented 8 years ago
somehow that was google terrain in non-onedirpermap mode rather than yahoo 
terrain in fact :-)

now works properly in onedirpermap mode however, as of r975

Original comment by Mark111...@gmail.com on 19 Aug 2010 at 7:35

GoogleCodeExporter commented 8 years ago
now works properly in non-onedirpermap mode, r976

Original comment by Mark111...@gmail.com on 19 Aug 2010 at 8:21

GoogleCodeExporter commented 8 years ago

Original comment by heldersepu on 19 Aug 2010 at 11:38