search

electric-it / minimart

MiniMart RubyGem for Chef cookbook mirroring and storage.
Apache License 2.0
52 stars 20 forks source link

Minimart crashes when trying to download 'bad' cookbook #22

Closed EYurchenko closed 8 years ago

EYurchenko commented 8 years ago

If Minimart tries to download a cookbook that is 'broken' then the whole process stops not allowing other cookbooks to be downloaded. Probably it's by design but in our case it represented a problem when we tried to mirror bunch of cookbooks off https://supermarket.chef.io . Example: -- Downloading sphinx 0.6.0 _opt_minimart: #<Zlib::GzipFile::Error: not in gzip format, input="sphinx

In our case desired behavior would be to log the error/warning and proceed with other cookbooks.
beeisabelm commented 8 years ago

I have experienced this issue as well. If one of the tags is not present, minimart does not rescue and continue the mirroring operation even though other cookbooks info on the .yml is valid.

tapickell commented 8 years ago

We have seen this too, I think it would be nice if it breaks on a cookbook it just skips that cookbook, keeps going with the rest and then gives you an error report for the cookbooks that failed at the end.

beeisabelm commented 8 years ago

:+1: Thank you. Our team LOVES this minimart and the homepage is a beauty!

tapickell commented 8 years ago

Thank you, it is great to hear people are using Minimart and like it. :smiley:

tapickell commented 8 years ago

PR resolves this issue