search

electric-it / minimart

MiniMart RubyGem for Chef cookbook mirroring and storage.
Apache License 2.0
52 stars 20 forks source link

Exposes source_url and issues_url of cookbook #30

Closed ge1st closed 8 years ago

ge1st commented 8 years ago

Resolves #29

So Ridley is setting these as empty strings, thus the ugly empty calls.

ui The cookbook detail now looks like ^^. Design guidance appreciated.

Anything I miss? Also didn't commit the minified css. Want me to?

tapickell commented 8 years ago

@ge1st Looks clean to me, I like it. Go ahead and add minified css. Thank you for your help. :+1:

richardardrichard commented 8 years ago

It has been a while since I've dug around in here, but since everything is a static file, I think you would actually need to commit the minified css in order for any users to actually see the changes. There are tasks in the Rakefile to compile_css, and compile_js.

tapickell commented 8 years ago

Created new issue about the process to minify CSS and JS files. https://github.com/electric-it/minimart/issues/31

tapickell commented 8 years ago

Going to merge this without Min CSS b/c next PR will remove need to Min by hand. Thank you @ge1st