search

electric-it / minimart

MiniMart RubyGem for Chef cookbook mirroring and storage.
Apache License 2.0
52 stars 20 forks source link

added check for existing git cookbook tag in local store. Should spee… #35

Closed AnalogJ closed 8 years ago

AnalogJ commented 8 years ago

…d up minimart mirror significantly.

This PR is missing tests. I'll work on that tonight.

fixes #34

AnalogJ commented 8 years ago

I could use a bit of direction here. The PR is working correctly. We have a few hundred different cookbook repos, with almost 4000 versions total. Minimart was taking around 30-40 minutes to mirror and rebuild the web cache each time, and now I that down to 5 minutes.

The issue is that I cant figure out how to get that one remaining test to pass. Any help would be appreciated.

tapickell commented 8 years ago

I can take a look at that test later today and see what I can figure out.

AnalogJ commented 8 years ago

Hey @tapickell, Actually I'd hold off on checking out the code. I spent some time last night diving into the internals of minimart some more, and I think I may have misunderstood the use of the matching_source? function. I'm going to take some time to think about this a bit more. I'll ping you again when I figure out how to do this properly.

I'll make sure to rebase this branch against master and squash my fixes before re-opening the PR.