search

electric-it / minimart

MiniMart RubyGem for Chef cookbook mirroring and storage.
Apache License 2.0
52 stars 20 forks source link

Fixes issue #47 with required ruby version #48

Closed tapickell closed 8 years ago

tapickell commented 8 years ago

This resolves issue #47 where the required ruby version was preventing install on Ruby 2.1.X but worked on 2.2.X and 2.3.X I am not 100% why this didn't work originally but would rather have it start from the lowest supported Ruby version to the latest version. I have testing this installing with versions: ruby-2.0.0-p648 [ x86_64 ] ruby-2.1.8 [ x86_64 ] ruby-2.2.3 [ x86_64 ] ruby-2.3.0 [ x86_64 ] ruby-2.3.1 [ x86_64 ]

Ruby 2.0.0 (EOL) fails all others succeed to install. Todd Pickell @tapickell tapickell@gmail.com

tapickell commented 8 years ago

strange this didn't break on travis testing at version 2.1.7

tapickell commented 8 years ago

Maybe we need a spec that asserts that the gem can be built and installed on each travis version???

tapickell commented 8 years ago

We now get The command "bundle exec rake install" exited with 0. in Travis build. This will fail if it fails to install on that version of Ruby.