search

electric-sheep-co / arduino-redis

A Redis client library for Arduino.
http://arduino-redis.com
MIT License
54 stars 19 forks source link

added Redis TimeSeries tsadd function to library #46

Closed gde-2 closed 3 years ago

gde-2 commented 3 years ago

as asked in the discussion "support for timeseries"

rpj commented 3 years ago

Excellent work and my sincere appreciation for your contribution to the project @gde-2! 🙌 ❤️

The code looks great, I'm happy to merge it straightaway!

rpj commented 3 years ago

In order to give you primary credit on the commit, you should merge this instead of me: if I do it myself I'll be the author and you the "Co-Author". You deserve full credit!

Simply click the "Squash and Merge" button then "Confirm squash and merge" (the commit message it fills in is fine), and that's it! Once it lands I'll fix up the repo for a new release and your change will be available soon in version 2.4.3!

Thank you again, and I sincerely hope this is the first of your many contributions to come 😄

gde-2 commented 3 years ago

Thanks for your kindness. I do not see a button to merge into the main branch, maybe I'm looking in the wrong place but to me it looks more like I do not have the permission to do so. I see a note on the pull request status: "Only those with write access to this repository can merge pull requests."

rpj commented 3 years ago

Oh geez... I could have sworn I already added you as a contributor, but apparently I had not. 🤦 My apologies for the confusion on that!

I've properly invited you with "write" access now, you should have the invite in your inbox and (as I understand it) once you accept that you'll have the buttons I mentioned and will be able to merge the PR. 👍