electric-sql / electric

Sync little subsets of your Postgres data into local apps and services.
https://electric-sql.com
Apache License 2.0
6.2k stars 146 forks source link

fix: remove deprecated "version" attribute from docker compose files #1716

Closed beorn closed 2 weeks ago

beorn commented 2 weeks ago

Seems safe to remove according to warning:

% docker compose -f .support/docker-compose.yml up
WARN[0000] .../.support/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
netlify[bot] commented 2 weeks ago

Deploy Preview for electric-next ready!

Name Link
Latest commit b963dca2d863c21674275e3ab4f280799f80f048
Latest deploy log https://app.netlify.com/sites/electric-next/deploys/66e878c584bf2b000803278c
Deploy Preview https://deploy-preview-1716--electric-next.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

KyleAMathews commented 2 weeks ago

We've left it in them as it is still required on older versions of Docker. I'm sure we can remove it at some point but it's pretty harmless otherwise to keep supporting older versions.

Thanks for helping improve Electric!