search

electric-sql / legacy-cli

ElectricSQL command line interface (CLI) tool.
https://electric-sql.com/docs
Apache License 2.0
10 stars 0 forks source link

Adding generation of postgresql files #3

Closed paulharter closed 2 years ago

paulharter commented 2 years ago

@thruflo this adds postgres file rendering but more relevant to you is that the js bundle structure has changed very slightly

paulharter commented 2 years ago

@define-null @icehaunter thank you both very much!

I make all the changes you suggest and trawl through to tidy other things up to follow similar patterns. Only it won't happen til Monday now.

thruflo commented 2 years ago

N.b.: re hot fix above, just flagging the bug up, didn't add a test, it's sanity testing it works for trailing slash, no training slash etc.

thruflo commented 2 years ago

@paulharter see https://github.com/electric-sql/cli/pull/5

paulharter commented 2 years ago

I've pretty much made all the changes as suggested - except the factoring out of file writing that @icehaunter suggests as I'm just about to move some things around for doing the postgres on the server in a way that will fix this

paulharter commented 2 years ago

I've also merged in James's changes

paulharter commented 2 years ago

i've made mistakes with misusing with fixing them now

paulharter commented 2 years ago

I think its all ok now

paulharter commented 2 years ago

@icehaunter is it ok to merge this in now?