search

electricessence / TypeScript.NET

A JavaScript-Friendly .NET Based TypeScript Library (Moved)
https://github.com/electricessence/TypeScript.NET-Core
Other
251 stars 36 forks source link

Code review of XObject #14

Closed electricessence closed 9 years ago

electricessence commented 9 years ago

XObject was just checked in at the level of which the .NET framework implements it. https://github.com/electricessence/TypeScript.NET/blob/develop-%28System.Xml.Linq%29/System.Xml.Linq/XObject.ts

It uses EventDispatcher and a new class called EventHelper to manage changing and changed events. Please review the XObject code since it will be a significant class for the rest of the System.Xml.Linq namespace.

electricessence commented 9 years ago

The XLinq.cs file is included for reference.

agnauck commented 9 years ago

looks good to me, I found no issues

electricessence commented 9 years ago

Great. I'll keep going from here. Was working on how to implement XmlConvert to make sure it matches what .NET does. Once that is done, then I can continue with XAttribute.