electricessence / TypeScript.NET

A JavaScript-Friendly .NET Based TypeScript Library (Moved)
https://github.com/electricessence/TypeScript.NET-Core
Other
251 stars 36 forks source link

Error after updating typescript to 2.4 #64

Closed bmarotta closed 7 years ago

bmarotta commented 7 years ago

After updating typescript to version 2.4 I get the following error while building. I'm using the umd version.

(...)/node_modules/typescript-dotnet-umd/System.Linq/Enumerable.d.ts(212,18): error TS2430: Interface 'NotEmptyEnumerable<T>' incorrectly extends interface 'ILinqEnumerable<T>'.
  Types of property 'aggregate' are incompatible.
    Type '(func: (previous: T, current: T) => T, seed?: T) => T' is not assignable to type '{ (func: (previous: T, current: T, index: number) => T, seed: T): T; (func: (previous: T, current...'.
      Types of parameters 'func' and 'func' are incompatible.
electricessence commented 7 years ago

Working on this.

electricessence commented 7 years ago

A lot of upgrades to the lib.d.ts file in 2.4

electricessence commented 7 years ago

Ok, I've made an update but left the min version as 2.3.2. It should be working now. If not, you should go back to 2.3.2 because 2.4 is currently having stack overflow issues:

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory https://github.com/Microsoft/TypeScript/issues/17097

bmarotta commented 7 years ago

Ok thanks. When do you have the stack overflow? ON my build it is not happening. But I'm just using some classes

On 14.07.2017 03:12, electricessence wrote:

Ok, I've made an update but left the min version as 2.3.2. It should be working now. If not, you should go back to 2.3.2 because 2.4 is currently having stack overflow issues:

|FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory| Microsoft/TypeScript#17097 https://github.com/Microsoft/TypeScript/issues/17097

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/electricessence/TypeScript.NET/issues/64#issuecomment-315242565, or mute the thread https://github.com/notifications/unsubscribe-auth/AHcQdsZmI9qIR_IAA56xY6QEBV4yE96Eks5sNsCGgaJpZM4OXcYJ.

electricessence commented 7 years ago

It doesn't happen to everyone. Just certain build situations. TS .NET has a complex build.

electricessence commented 7 years ago

Did the new npm package solve your problem?

bmarotta commented 7 years ago

Yes

On 14.07.2017 07:00, electricessence wrote:

Did the new npm package solve your problem?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/electricessence/TypeScript.NET/issues/64#issuecomment-315270367, or mute the thread https://github.com/notifications/unsubscribe-auth/AHcQdikzAQXMTKQ88dy_7i_6c4SYP2Skks5sNvX-gaJpZM4OXcYJ.

electricessence commented 7 years ago

GREAT!

bmarotta commented 7 years ago

Thanks for the fast support!

On 14.07.2017 07:03, electricessence wrote:

GREAT!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/electricessence/TypeScript.NET/issues/64#issuecomment-315270700, or mute the thread https://github.com/notifications/unsubscribe-auth/AHcQdhM-uU0y8AoB4ECozmA_BQBu4PuFks5sNva0gaJpZM4OXcYJ.

electricessence commented 7 years ago

Dude, thank you for letting me know!