search

electricessence / TypeScript.NET

A JavaScript-Friendly .NET Based TypeScript Library (Moved)
https://github.com/electricessence/TypeScript.NET-Core
Other
251 stars 36 forks source link

toString() in System/Text/StringBuilder does not work well #69

Closed RYOSKATE closed 6 years ago

RYOSKATE commented 6 years ago

toString () always returns null whatever I append. It seems to be because _latest always has the value of null. (about dist/es6)

electricessence commented 6 years ago

@RYOSKATE Will fix immediately.

electricessence commented 6 years ago

https://github.com/electricessence/TypeScript.NET/blob/3ece39d04b83724383ea317764313298ee2a4d59/source/System/Text/StringBuilder.ts#L110

Bad comparison on line 110.

electricessence commented 6 years ago

https://www.npmjs.com/package/typescript-dotnet-umd

All fixed: https://github.com/electricessence/TypeScript.NET/commit/76049732c206a34b52896e265f69b10e19cc7b34

electricessence commented 6 years ago

@RYOSKATE Thank you so much for you submission! Now that a test has been added, shouldn't have any issues. Surprised this slipped through. Also, .toString() if it worked, returned comma separated values! Now it works properly. :)

RYOSKATE commented 6 years ago

I can confirm it. Thank you for your prompt action!

electricessence commented 6 years ago

@RYOSKATE You're very welcome!