Si7021 - Githubissues

Class looks really good! Sorry for taking so long to review.

A few things:

I think you should allow the constructor to override the device's slave address, even if the hardware doesn't support it. You can use an optional argument in the constructor with a default value:

constructor(_i2c, _addr = ADDR) { addr = ADDR; i2c = _i2c; }

You should note in the comments at the top of the class:
- the fact that the I2C peripheral must be pre-configured
- the datasheet URL
In the README, you note that you need 10kΩ pull-ups. These can really be anywhere from 1k to 10k, or even greater, especially if you're running at low speed. I usually recommend 4.7kΩ. Your call whether that's worth changing or not; it's not incorrect!

Thanks for the well-written class!

electricimp / reference