electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.

https://www.bloomclimate.com

MIT License

436 stars 104 forks source link

Add carbon footprint for pasta, cream, sour cream, ice cream and butter #180

Closed honsq90 closed 5 years ago

honsq90 commented 5 years ago

Hope this is correct! Let me know if there's anything else I should do

68

martincollignon commented 5 years ago

Thanks for these findings!

The dairy study has a few crazy numbers (butter!), I'd prefer to stay on the dairy numbers shown in this PR https://github.com/tmrowco/tmrowapp-contrib/pull/131/files as it's systemic review with a lot of studies
Great for the pasta!
For the ice cream, could you add the 4 different variants in the study?

Overall, would you mind committing to this PR instead: https://github.com/tmrowco/tmrowapp-contrib/pull/131/ ?

We're doing a bit of cleaning up before merging and I expect to be able to get these data points at the same time.

Good job!

honsq90 commented 5 years ago

yep will do! pretty interesting stuff to read over here haha

is that branch open for other contributors to push to? or do I raise a PR to merge to that branch?

corradio commented 5 years ago

It will be easier if you raise a PR to merge to that branch.

Thanks!

Olivier

On Thu, Oct 3, 2019 at 1:46 AM Shuqian Hon notifications@github.com wrote:

yep will do! pretty interesting stuff to read over here haha

is that branch open for other contributors to push to? or do I raise a PR to merge to that branch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/pull/180?email_source=notifications&email_token=AAMUIKDVJBSH5ZAHO4FGGZ3QMUXFFA5CNFSM4I4WMIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAGQ5KA#issuecomment-537726632, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMUIKHPM7BCOEB54THGQXLQMUXFFANCNFSM4I4WMIVQ .

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

martincollignon commented 5 years ago

Hi @honsq90 . The big branch mentioned above was merged earlier today. Any chance you can update your PR?

martincollignon commented 5 years ago

Good luck with the move and thanks for getting back to me!

We're revamping the CO2eq as we speak, can you PR on this branch if you do it today? https://github.com/tmrowco/tmrowapp-contrib/pull/193

On Thu, Oct 10, 2019, 22:46 Shuqian Hon notifications@github.com wrote:

hey sorry @martincollington, just moved between countries recently and have been transitioning. I'll get on this now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/pull/180?email_source=notifications&email_token=AAT333RM5XNNILP7O4RBNZDQN6ICJA5CNFSM4I4WMIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA53YZY#issuecomment-540785767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT333S5D63XWU3RE2QGNTTQN6ICJANCNFSM4I4WMIVQ .

honsq90 commented 5 years ago

woops, was going to rewrite the comment cause I was on mobile. apologies for the deleted comment. yep will PR to that branch :)

honsq90 commented 5 years ago

closing in favour of #195

alph4delta commented 5 years ago