Closed martincollignon closed 4 years ago
@martincollignon If possible, could I tackle this issue?
Sure! Go ahead!
On Thu, Oct 17, 2019, 20:28 Abdullah Pathan notifications@github.com wrote:
@martincollignon https://github.com/martincollignon Could I tackle this issue?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/issues/205?email_source=notifications&email_token=AAT333VHKT2I3BPXX3IA33DQPCVEHA5CNFSM4JBYKJRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRCM3Y#issuecomment-543303279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT333T5FHNINAYYMPLCVEDQPCVEHANCNFSM4JBYKJRA .
Thanks! I've updated the file, please let me know if it needs to be revised or more changes are needed: https://github.com/tmrowco/tmrowapp-contrib/pull/207
Thanks @Aonepathan !
To others: There are plenty of other type of foods where we could use some help :-)
@martincollignon I would like to help. Can you please guide?
Sounds great! @mathagician! If you check the https://github.com/tmrowco/tmrowapp-contrib/blob/master/co2eq/purchase/footprints.yml file, this is where we store both the carbon intensity of items and the median portion sizes of these. It would be super appreciated if you could look around the web for data around both!
Hi @martincollignon I added some more servings, see #222. Hope it's what you expected 🙂
Do you still need help with this issue? I can help out!
Hi @asaki444 ! Yes, very simply, we would need to find average servings for food items here (some of them already have them): https://github.com/tmrowco/northapp-contrib/blob/master/co2eq/purchase/footprints.yml#L1182
Closing due to inactivity
Should be added to https://github.com/tmrowco/tmrowapp-contrib/blob/master/co2eq/purchase/footprints.yml . There is an example already implemented with "Apple": https://github.com/tmrowco/tmrowapp-contrib/blob/9fd0eb6260996910f8b47e0f1ce66360edeec52c/co2eq/purchase/footprints.yml#L392